Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carol/ Search box hotfix #5749

Merged
merged 11 commits into from
Jun 20, 2022
Merged

carol/ Search box hotfix #5749

merged 11 commits into from
Jun 20, 2022

Conversation

carolsachdeva
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fix search box hotfix

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Jun 16, 2022
@vercel
Copy link

vercel bot commented Jun 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 5:26PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/5749](https://github.com/binary-com/deriv-app/pull/5749)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-carol-binary-search-hotfix.binary.sx?qa_server=frontend.binaryws.com&app_id=32112
    - **Original**: https://deriv-app-git-fork-carol-binary-search-hotfix.binary.sx
- **App ID**: `32112`

matin-deriv
matin-deriv reviewed Jun 17, 2022
View reviewed changes
packages/p2p/src/components/search-box/search-box.jsx Outdated
Comment on lines 17 to 21
if (!search) {
onClear();
} else {
submitForm();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using ternary operators to simplify/shorter the code.

matin-deriv
matin-deriv previously approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #5749 (abfc7b3) into master (9db1289) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5749      +/-   ##
==========================================
- Coverage   20.90%   20.90%   -0.01%     
==========================================
  Files        1287     1287              
  Lines       29261    29263       +2     
  Branches     4930     4930              
==========================================
  Hits         6117     6117              
- Misses      22805    22807       +2     
  Partials      339      339
Impacted Files Coverage Δ
...kages/p2p/src/components/search-box/search-box.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db1289...abfc7b3. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

adrienne-deriv
adrienne-deriv approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@carolsachdeva carolsachdeva merged commit 3b54f8a into deriv-com:master Jun 20, 2022
vinu-deriv pushed a commit to vinu-deriv/deriv-app that referenced this pull request Jun 21, 2022
@carolsachdeva @vinu-deriv
carol/ Search box hotfix (deriv-com#5749)
d2ee842 
* search hotfix

* search hotfix

* fix: intermittent issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@aswathy-deriv aswathy-deriv aswathy-deriv approved these changes

@matin-deriv matin-deriv matin-deriv left review comments

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

Assignees
No one assigned
Labels
P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carolsachdeva @codecov-commenter @matin-deriv @aswathy-deriv @adrienne-deriv